[
https://issues.apache.org/jira/browse/ARTEMIS-5956?focusedWorklogId=1010378&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1010378
]
ASF GitHub Bot logged work on ARTEMIS-5956:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/26 15:35
Start Date: 19/Mar/26 15:35
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #6300:
URL: https://github.com/apache/artemis/pull/6300#discussion_r2960879813
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSTemporaryDestinationTest.java:
##########
@@ -137,4 +139,69 @@ public void testDeleteTemporaryTopic() throws Exception {
connection.close();
}
}
+
+ @Test
+ @Timeout(20)
+ public void testTemporaryTopicDeletedOnConnectionClosed() throws Exception {
+ doTestTemporaryDestinationIsDeletedOnConnectionClosed(true, true);
+ }
+
+ @Test
+ @Timeout(20)
+ public void testTemporaryQueueDeletedOnConnectionClosed() throws Exception {
+ doTestTemporaryDestinationIsDeletedOnConnectionClosed(false, true);
+ }
+
+ @Test
+ @Timeout(20)
+ public void
testTemporaryTopicDeletedOnConnectionClosedWithoutExplicitConsumerClose()
throws Exception {
+ doTestTemporaryDestinationIsDeletedOnConnectionClosed(true, false);
+ }
+
+ @Test
+ @Timeout(20)
+ public void
testTemporaryQueueDeletedOnConnectionClosedWithoutExplicitConsumerClose()
throws Exception {
+ doTestTemporaryDestinationIsDeletedOnConnectionClosed(false, false);
+ }
+
+ private void doTestTemporaryDestinationIsDeletedOnConnectionClosed(boolean
topic, boolean closeConsumer) throws Exception {
+ final String addressName;
+ try (Connection connection = createConnection()) {
+ final Session session = connection.createSession(false,
Session.AUTO_ACKNOWLEDGE);
+ final Destination destination;
+
+ if (topic) {
+ destination = session.createTemporaryTopic();
+
+ assertNotNull(destination);
+ assertTrue(destination instanceof TemporaryTopic);
+
+ addressName = ((TemporaryTopic) destination).getTopicName();
+ } else {
+ destination = session.createTemporaryQueue();
+
+ assertNotNull(destination);
+ assertTrue(destination instanceof TemporaryQueue);
+
+ addressName = ((TemporaryQueue) destination).getQueueName();
+ }
+
+ logger.info("Address being used is {}", addressName);
Review Comment:
logger.info -> logger.debug
Issue Time Tracking
-------------------
Worklog Id: (was: 1010378)
Time Spent: 1.5h (was: 1h 20m)
> Temporary Addresses may leak when consumer is not yet closed
> ------------------------------------------------------------
>
> Key: ARTEMIS-5956
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5956
> Project: Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> say you create a temporary destination, and close the connection with the
> consumer open.
> Depending on pending executions the destination may leak:
> {code:java}
> try (Connection connection = createConnection()) {
> Session session = connection.createSession(false,
> Session.AUTO_ACKNOWLEDGE);
> Topic temporaryTopic = session.createTemporaryTopic();
> MessageProducer producer = session.createProducer(temporaryTopic);
> MessageConsumer consumer =
> session.createSharedConsumer(temporaryTopic, "mySub");
> connection.start();
> temporarytopicName = temporaryTopic.getTopicName();
> producer.send(session.createMessage());
> assertNotNull(consumer.receive(5000));
> }
> Wait.assertTrue(() ->
> server.getAddressInfo(SimpleString.of(temporarytopicName)) == null, 5000,
> 100);
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
