clebertsuconic commented on code in PR #6300:
URL: https://github.com/apache/artemis/pull/6300#discussion_r2960920994
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/TransientQueueManagerImpl.java:
##########
@@ -52,7 +52,9 @@ private void doIt() {
}
public TransientQueueManagerImpl(ActiveMQServer server, SimpleString
queueName) {
- super(server.getExecutorFactory().getExecutor());
+ /* We cannot use a separate executor to delete transient queues as that
would
+ * introduce races on the ServerSessionImpl::TempQueueCleaner. */
+ super();
Review Comment:
even though I'm using a single executor here, it was not possible to
completely avoid the need to retry the execution.
the consumer.close could be happening after removeAddress is triggered. So,
I'm just retrying up to 5 times. (1 time should been enough).
I don't think we should allow configuration for this max-retry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
