tabish121 commented on code in PR #6323:
URL: https://github.com/apache/artemis/pull/6323#discussion_r3054514676
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java:
##########
@@ -155,7 +155,7 @@ public abstract class AMQPMessage extends RefCountMessage
implements org.apache.
* developing purposes.
*/
public enum MessageDataScanningStatus {
- NOT_SCANNED(0), SCANNED(1);
+ NOT_SCANNED(0), RELOAD_PERSISTENCE(1), SCANNED(2);
Review Comment:
So since you are now storing the memory estimate in the V4 persistent form
can you not alter `recoverHeaderDataFromEncoding` to provide it the version you
are recovering from if less than V4 you also scan and load the values from the
encoded ApplicationPropreties if present (using the existing `parseAndSkip`
method) and thereby remove the need for the RELOAD_PERSISTENCE state that you
wanted to remove. The code would just need to know when to stop scanning which
would be either as soon as a Header was read, or under a similar set of
constraints as `scanMessageData` where it stops after having hit the body
sections or a Footer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
