[
https://issues.apache.org/jira/browse/ARTEMIS-5573?focusedWorklogId=1014120&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1014120
]
ASF GitHub Bot logged work on ARTEMIS-5573:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/26 22:27
Start Date: 08/Apr/26 22:27
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #6323:
URL: https://github.com/apache/artemis/pull/6323#discussion_r3054514676
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java:
##########
@@ -155,7 +155,7 @@ public abstract class AMQPMessage extends RefCountMessage
implements org.apache.
* developing purposes.
*/
public enum MessageDataScanningStatus {
- NOT_SCANNED(0), SCANNED(1);
+ NOT_SCANNED(0), RELOAD_PERSISTENCE(1), SCANNED(2);
Review Comment:
So since you are now storing the memory estimate in the V4 persistent form
can you not alter `recoverHeaderDataFromEncoding` to provide it the version you
are recovering from if less than V4 you also scan and load the values from the
encoded ApplicationPropreties if present (using the existing `parseAndSkip`
method) and thereby remove the need for the RELOAD_PERSISTENCE state that you
wanted to remove. The code would just need to know when to stop scanning which
would be either as soon as a Header was read, or under a similar set of
constraints as `scanMessageData` where it stops after having hit the body
sections or a Footer
Issue Time Tracking
-------------------
Worklog Id: (was: 1014120)
Time Spent: 8h 10m (was: 8h)
> Make AMQP Size immutable
> ------------------------
>
> Key: ARTEMIS-5573
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5573
> Project: Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.41.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> I have had a lot of issues, even recently on races between re-evaluating a
> message size in AMQP.
> Say a lazy decode happens at the wrong time and the memory estimates can be
> wrong.
> We have fixed issues along the years, but this is still a fragile process
> that is bound to fail. If an user for instance add a plugin breaking the
> chain of events.
> For that reason the memory estimate should already include enough estimation
> for any properties decoded and the process should be simplified.
> Less moving parts would mean less possibilities for bugs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
