clebertsuconic commented on code in PR #6396:
URL: https://github.com/apache/artemis/pull/6396#discussion_r3174672722
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterController.java:
##########
@@ -407,11 +407,19 @@ public void handlePacket(Packet packet) {
ClusterConnectMessage msg = (ClusterConnectMessage) packet;
- if (server.getConfiguration().isSecurityEnabled() &&
!clusterConnection.verify(msg.getClusterUser(), msg.getClusterPassword())) {
- clusterChannel.send(new ClusterConnectReplyMessage(false));
- } else {
+ boolean userIsValid = false;
+ try {
+ server.validateUser(msg.getClusterUser(),
msg.getClusterPassword(), null, null);
+ userIsValid = true;
+ } catch (Exception e) {
+ // cluster user isn't valid
Review Comment:
@jbertram I was recently in a customer case and the code was "eating" an
exception like this.
Even though this is logged else, I would appreciate if we had at least
log.debug(e.getMessage(), e) (or trace if you prefer).
I would avoid any sort of "eating" an exception, without log.debug or trace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
