gemmellr commented on code in PR #29: URL: https://github.com/apache/artemis-examples/pull/29#discussion_r3189505296
########## examples/features/standard/security-oidc/pom.xml: ########## @@ -0,0 +1,182 @@ +<?xml version='1.0'?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <parent> + <groupId>org.apache.artemis.examples.broker</groupId> + <artifactId>jms-examples</artifactId> + <version>2.53.0</version> Review Comment: Version should be 2.54.0-SNAPSHOT, thats why the compile job failed on Java 25 (which for nuance is the only one that will compile this as it is using the release profile). Although the jobs normally update the examples versions to match the Artemis version if needed...it checks the existing version at the root, and those matched already, so it didnt update (in part to find issues like this). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
