clebertsuconic commented on code in PR #6419:
URL: https://github.com/apache/artemis/pull/6419#discussion_r3209511702
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java:
##########
@@ -444,9 +445,17 @@ private String getClusterUser() {
return clusterUser;
}
- private String getClusterPassword() {
+ protected String getClusterPassword() {
if (clusterPassword == null) {
clusterPassword = inputPassword("--cluster-password", "What is the
cluster password?", "password-admin");
+ try {
+ clusterPassword =
PasswordMaskingUtil.wrap(PasswordMaskingUtil.getDefaultCodec().encode(clusterPassword));
Review Comment:
@jbertram I don't understand this.. you're only masking the password *if*
sent through the input..
I think if you did ./artemis create --cluster --password myPassowrd
it should also be masked, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
