jbertram commented on PR #6426: URL: https://github.com/apache/artemis/pull/6426#issuecomment-4421058037
This looks good. However, it would be nice to have some tests around the history file, especially confirming the permissions are set appropriately. I think you can mock input similar to the recently added `org.apache.activemq.artemis.cli.commands.CreateTestIndividualSettings#testMaskAdminPasswordUserInput` . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
