[
https://issues.apache.org/jira/browse/ARTEMIS-6051?focusedWorklogId=1019723&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1019723
]
ASF GitHub Bot logged work on ARTEMIS-6051:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/26 18:28
Start Date: 11/May/26 18:28
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #6426:
URL: https://github.com/apache/artemis/pull/6426#discussion_r3221212233
##########
artemis-cli/src/test/java/org/apache/activemq/artemis/cli/commands/ShellTest.java:
##########
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.cli.commands;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import java.io.ByteArrayInputStream;
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.attribute.PosixFilePermission;
+import java.util.Set;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.activemq.artemis.cli.Shell;
+import org.apache.activemq.artemis.tests.util.ArtemisTestCase;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
+
+public class ShellTest extends ArtemisTestCase {
+
+ @TempDir
+ File temporaryFolder;
+
+ @Test
+ public void testDefaultAllowHistory() throws Exception {
+ testDefaultHistory(true);
+ }
+
+ @Test
+ public void testDefaultDontAllowHistory() throws Exception {
+ testDefaultHistory(true);
Review Comment:
Shouldn't this be passing `false`?
Issue Time Tracking
-------------------
Worklog Id: (was: 1019723)
Time Spent: 2h (was: 1h 50m)
> Use ~/.artemis_history for shell history by default on Linux
> ------------------------------------------------------------
>
> Key: ARTEMIS-6051
> URL: https://issues.apache.org/jira/browse/ARTEMIS-6051
> Project: Artemis
> Issue Type: Improvement
> Affects Versions: 2.53.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.54.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
