clebertsuconic commented on code in PR #6436:
URL: https://github.com/apache/artemis/pull/6436#discussion_r3226777642
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java:
##########
@@ -451,7 +451,7 @@ protected void setClusterPassword(String clusterPassword) {
protected String getClusterPassword() {
if (clusterPassword == null) {
- clusterPassword = inputPassword("--cluster-password", "What is the
cluster password?", "password-admin");
+ clusterPassword = inputPassword("--cluster-password", "What is the
cluster password?", ActiveMQDefaultConfiguration.getDefaultClusterPassword());
Review Comment:
I would remove the default argument on inputPassword, and throw an exception
if not passed, and while in silent..
I have a branch with this suggestion:
https://github.com/clebertsuconic/artemis/tree/ARTEMIS-6037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
