[
https://issues.apache.org/jira/browse/ARTEMIS-5972?focusedWorklogId=1021509&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1021509
]
ASF GitHub Bot logged work on ARTEMIS-5972:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/May/26 14:23
Start Date: 21/May/26 14:23
Worklog Time Spent: 10m
Work Description: mayankkunwar commented on code in PR #6444:
URL: https://github.com/apache/artemis/pull/6444#discussion_r3281895153
##########
artemis-ffm/src/test/java/org/apache/artemis/nativo/jlibaio/test/jmh/AioCompareBenchmark.java:
##########
@@ -0,0 +1,193 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.artemis.nativo.jlibaio.test.jmh;
+
+import org.apache.artemis.nativo.jlibaio.LibaioContext;
+import org.apache.artemis.nativo.jlibaio.LibaioFile;
+import org.apache.artemis.nativo.jlibaio.SubmitInfo;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Fork;
+import org.openjdk.jmh.annotations.Level;
+import org.openjdk.jmh.annotations.Measurement;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Param;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.Setup;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.annotations.TearDown;
+import org.openjdk.jmh.annotations.Warmup;
+
+import java.io.File;
+import java.lang.foreign.MemorySegment;
+import java.nio.ByteBuffer;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReference;
+
+@State(Scope.Benchmark)
+@BenchmarkMode(Mode.AverageTime)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@Fork(value = 2)
+@Warmup(iterations = 5, time = 200, timeUnit = TimeUnit.MILLISECONDS)
+@Measurement(iterations = 10, time = 200, timeUnit = TimeUnit.MILLISECONDS)
+public class AioCompareBenchmark {
+
+ private static final int FILE_SIZE = 10000 * 4096;
+ private static final int BLOCK_SIZE = 4096;
+
+ @Param({"2048"})
+ private int LIBAIO_QUEUE_SIZE;
+
+ @Param({"10000"})
+ private int recordCount;
+
+ private File file;
+ private LibaioContext<SubmitInfo> control;
+ private LibaioFile<SubmitInfo> libaioFile;
+
+ private MemorySegment headerSegment;
+ private ByteBuffer headerBuffer;
+
+ private MemorySegment recordSegment;
+ private ByteBuffer recordBuffer;
+
+ private final AtomicReference<CountDownLatch> currentLatch = new
AtomicReference<>();
+
+ private Thread pollThread;
+ private volatile boolean polling = true;
+
+ private final SubmitInfo callback = new SubmitInfo() {
+ @Override
+ public void onError(int errno, String message) {
+ //ignore
+ }
+
+ @Override
+ public void done() {
+ CountDownLatch latch = currentLatch.get();
+ if (latch != null) {
+ latch.countDown();
+ }
+ }
+ };
+
+ private long fileId = 1L;
+
+ @Setup(Level.Trial)
+ public void setuo() throws Exception {
+ file = File.createTempFile("aio-bench-", ".dat");
+
+ control = new LibaioContext<>(LIBAIO_QUEUE_SIZE, true, true);
+ libaioFile = control.openFile(file, true);
+
+ //one-time file initialization
+ libaioFile.fallocate(FILE_SIZE);
+
+ headerSegment = LibaioContext.newAlignedBuffer(BLOCK_SIZE, BLOCK_SIZE);
+ headerBuffer = headerSegment.asByteBuffer();
+
+ recordSegment = LibaioContext.newAlignedBuffer(BLOCK_SIZE, BLOCK_SIZE);
+ recordBuffer = recordSegment.asByteBuffer();
+
+ initRecord(headerBuffer); // filling the record clock with 1
+ initRecord(recordBuffer); // filling the record clock with 1
+
+ fillHeader(fileId);
+ updateRecord(recordBuffer, fileId, 0L);
+
+ polling = true;
+ pollThread = new Thread(() -> {
+ while (polling && !Thread.currentThread().isInterrupted()) {
+ try {
+ control.poll();
+ } catch (Throwable e) {
+ if (polling) {
+ throw new RuntimeException(e);
+ }
+ break;
+ }
+ }
+ }, "aio-jmh-poll-thread");
+ pollThread.setDaemon(true);
+ pollThread.start();
+ }
+
+ @TearDown(Level.Trial)
+ public void tearDown() throws Exception {
+ polling = false;
+ if (pollThread != null) {
+ pollThread.interrupt();
+ pollThread.join(TimeUnit.SECONDS.toMillis(10));
+ }
+
+ if (libaioFile != null) {
+ libaioFile.close();
+ }
+ if (control != null) {
+ control.close();
+ }
+ if (headerSegment != null && headerSegment.address() != 0) {
+ LibaioContext.freeBuffer(headerSegment);
+ }
+ if (recordSegment != null && recordSegment.address() != 0) {
+ LibaioContext.freeBuffer(recordSegment);
+ }
+ if (file != null) {
+ file.delete();
+ }
+ }
+
+ @Benchmark
+ public void writeHeaderAndRecord() throws Exception {
+ CountDownLatch latch = new CountDownLatch(recordCount * 100);
+ currentLatch.set(latch);
+
+ try {
+ // fillHeader(fileId);
+ // libaioFile.write(0L, BLOCK_SIZE, headerBuffer,
callback);
Review Comment:
Sure, let me remove them.
##########
artemis-ffm/src/test/java/org/apache/artemis/nativo/jlibaio/test/jmh/AioCompareBenchmark.java:
##########
@@ -0,0 +1,193 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.artemis.nativo.jlibaio.test.jmh;
+
+import org.apache.artemis.nativo.jlibaio.LibaioContext;
+import org.apache.artemis.nativo.jlibaio.LibaioFile;
+import org.apache.artemis.nativo.jlibaio.SubmitInfo;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Fork;
+import org.openjdk.jmh.annotations.Level;
+import org.openjdk.jmh.annotations.Measurement;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Param;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.Setup;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.annotations.TearDown;
+import org.openjdk.jmh.annotations.Warmup;
+
+import java.io.File;
+import java.lang.foreign.MemorySegment;
+import java.nio.ByteBuffer;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReference;
+
+@State(Scope.Benchmark)
+@BenchmarkMode(Mode.AverageTime)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@Fork(value = 2)
+@Warmup(iterations = 5, time = 200, timeUnit = TimeUnit.MILLISECONDS)
+@Measurement(iterations = 10, time = 200, timeUnit = TimeUnit.MILLISECONDS)
+public class AioCompareBenchmark {
Review Comment:
okay
Issue Time Tracking
-------------------
Worklog Id: (was: 1021509)
Time Spent: 1h 50m (was: 1h 40m)
> Replace JNI with Panama Foreign Function & Memory (FFM) API for Journal
> Native Layer
> ------------------------------------------------------------------------------------
>
> Key: ARTEMIS-5972
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5972
> Project: Artemis
> Issue Type: Improvement
> Components: Native
> Reporter: Mayank Kunwar
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Proposing a modernization of the artemis-journal module by leveraging the
> Panama Foreign Function & Memory (FFM) API (introduced in JDK 22). This will
> provide a high-performance alternative to the existing JNI-based native layer
> for interacting with libaio.
>
> ||Feature||Current JNI + libaio||Modernize Journal||
> |Call Type|Java -> JNI (C code) -> libaio |Java -> Panama FFM -> libaio|
> |Code Base|Java + C/C++ (Native Repo)|100% Pure Java|
> |I/O Mechanism |Asynchronous via libaio callbacks|Asynchronous via libaio
> callbacks|
> |Efficiency|Higher overhead (JNI transitions)|Lower overhead (JIT optimized)|
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
