[ 
https://issues.apache.org/jira/browse/AURORA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529520#comment-14529520
 ] 

Bill Farner commented on AURORA-1305:
-------------------------------------

https://reviews.apache.org/r/33869/

> MemTaskStore: items are not removed from secondary index
> --------------------------------------------------------
>
>                 Key: AURORA-1305
>                 URL: https://issues.apache.org/jira/browse/AURORA-1305
>             Project: Aurora
>          Issue Type: Story
>          Components: Scheduler
>            Reporter: Bill Farner
>            Assignee: Bill Farner
>            Priority: Minor
>
> An updated PMD flagged this bug (see output below).
> This line:
> {code}
> index.remove(key, task);
> {code}
> should be:
> {code}
> index.remove(key, Tasks.id(task));
> {code}
> {noformat}
> Code  Warning
> GC    org.apache.aurora.scheduler.storage.entities.IScheduledTask is 
> incompatible with expected argument type String in 
> org.apache.aurora.scheduler.storage.mem.MemTaskStore$SecondaryIndex.remove(IScheduledTask)
> Bug type GC_UNRELATED_TYPES (click for details) 
> In class org.apache.aurora.scheduler.storage.mem.MemTaskStore$SecondaryIndex
> In method 
> org.apache.aurora.scheduler.storage.mem.MemTaskStore$SecondaryIndex.remove(IScheduledTask)
> Actual type org.apache.aurora.scheduler.storage.entities.IScheduledTask
> Expected String
> Called method com.google.common.collect.Multimap.remove(Object, Object)
> Invoked on 
> org.apache.aurora.scheduler.storage.mem.MemTaskStore$SecondaryIndex.index
> task passed as argument
> org.apache.aurora.scheduler.storage.entities.IScheduledTask.equals(Object) 
> used to determine equality
> At MemTaskStore.java:[line 399]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to