[ 
https://issues.apache.org/jira/browse/AURORA-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jay Buffington updated AURORA-1376:
-----------------------------------
    Comment: was deleted

(was: Glad to see there is progress on this!

IMHO, it's odd and confusing that your JSON here doesn't map more closely to 
the ExecutorInfo that will go into the protobuf we send to the mesos master 
(see 
https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L310).  
For example, executorFlags is something that is set in a CommandInfo which goes 
inside the ExecutorInfo.

Also, the mesos-command executor is this odd duck because it's the executor you 
get when you don't specify an ExecutorInfo.  

I think we're going to have a plugin model.  I would start by implementing an 
abstract class which you would have to implement if you wanted to use a custom 
executor.  Initially, I would just provide two implementations: one for thermos 
and one for the mesos executor.  We can get fancy and do dynamic loading of 
alternative plugins in the second phase.

Which plugin to use would be driven by the thrift request the client sent.  I 
think your JSON configuration is still necessary, but I each config is unique 
for the plugin.  The rest of the schedule would treat that configuration 
opaquely.

We could have a couple of command line options to support this.

    --enabled-executors=mesos,thermos,foo
    --executors-config=
    {
       "thermos": {
           // configuration only thermos plugin understand goes here
       },
       "foo": {
           // config for foo executor
       }
    }


(the json for --executors-config needs to be properly escaped, but you get the 
idea)

)

> Create support for custom executors in Scheduler
> ------------------------------------------------
>
>                 Key: AURORA-1376
>                 URL: https://issues.apache.org/jira/browse/AURORA-1376
>             Project: Aurora
>          Issue Type: Sub-task
>          Components: Scheduler
>            Reporter: Renan DelValle
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to