[
https://issues.apache.org/jira/browse/AURORA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726188#comment-14726188
]
Zameer Manji commented on AURORA-1380:
--------------------------------------
Un assigning this ticket from me because this appears to be blocked on
improving shiro-guice. Once that has been completed we just need to apply the
following patch to build.gradle:
{noformat}
[tw-mbp-zmanji asf-aurora (zmanji/upgrade-guice)]$ git diff master
diff --git a/build.gradle b/build.gradle
index 9c78aff..eb87e3f 100644
--- a/build.gradle
+++ b/build.gradle
@@ -85,7 +85,7 @@ For more details, please see
https://issues.apache.org/jira/browse/AURORA-1169
ext.guavaRev = '18.0'
ext.slf4jRev = '1.7.12'
ext.thriftRev = '0.9.1'
- ext.guiceRev = '3.0'
+ ext.guiceRev = '4.0'
ext.servletRev = '2.5'
ext.stringTemplateRev = '3.2.1'
ext.zookeeperRev = '3.3.4'
@@ -110,6 +110,10 @@ For more details, please see
https://issues.apache.org/jira/browse/AURORA-1169
force "org.hamcrest:hamcrest-core:1.3"
force "org.apache.thrift:libthrift:${thriftRev}"
force "org.slf4j:slf4j-jdk14:${slf4jRev}"
+ force "com.google.guava:guava:${guavaRev}"
+ force "com.google.inject:guice:${guiceRev}"
+ force "com.google.inject.extensions:guice-multibindings:${guiceRev}"
+ force "com.google.inject.extensions:guice-servlet:${guiceRev}"
}
}
}
@@ -153,6 +157,7 @@ project(':commons') {
compile "com.google.code.gson:gson:${gsonRev}"
compile "com.google.guava:guava:${guavaRev}"
compile "com.google.inject.extensions:guice-multibindings:${guiceRev}"
+ compile "com.google.inject.extensions:guice-servlet:${guiceRev}"
compile "com.google.inject:guice:${guiceRev}"
compile "com.sun.jersey.contribs:jersey-guice:${jerseyRev}"
compile "com.sun.jersey:jersey-core:${jerseyRev}
{noformat}
> Upgrade to guice 4.0
> --------------------
>
> Key: AURORA-1380
> URL: https://issues.apache.org/jira/browse/AURORA-1380
> Project: Aurora
> Issue Type: Story
> Components: Scheduler
> Reporter: Kevin Sweeney
> Priority: Critical
>
> Guice 4.0 has been released. Among the new features, probably the most
> significant is Java 8 support - in Guice 3.0 stack traces are obfuscated by
> https://github.com/google/guice/issues/757. As our code expands use of
> lambdas and method references this will become even more critical.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
