[
https://issues.apache.org/jira/browse/AURORA-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15691616#comment-15691616
]
Mehrdad Nurolahzade commented on AURORA-1825:
---------------------------------------------
Just as a side note:
It would be interesting to see benchmarks on logging with expensive reflection
based patterns like class name or line number removed. I did not find anything
on this on Logback but Log4j documentation, for example, explicitly warns
against using such patterns in performance critical systems:
[https://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html]
{quote}WARNING Generating the caller class information is slow. Thus, use
should be avoided unless execution speed is not an issue.{quote}
{quote}WARNING Generating caller location information is extremely slow and
should be avoided unless execution speed is not an issue.{quote}
> Enable async logging by default
> -------------------------------
>
> Key: AURORA-1825
> URL: https://issues.apache.org/jira/browse/AURORA-1825
> Project: Aurora
> Issue Type: Task
> Reporter: Zameer Manji
> Assignee: Jing Chen
> Priority: Minor
>
> Based on my experience while working on AURORA-1823 and [~StephanErb]'s work
> on logging recently, I think it would be best if we enabled async logging.
> For example if one attempts to parallelize the work inside
> {{StateManagerImpl}} there isn't much benefit because all of the state
> transitions are logged and all of the threads would contend for the lock.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
