[
https://issues.apache.org/jira/browse/AURORA-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940592#comment-15940592
]
Joshua Cohen edited comment on AURORA-1871 at 3/24/17 3:46 PM:
---------------------------------------------------------------
I don't think we need to do this verification in Pystachio, nor do we need to
write a parser for the DSL (which Pystachio already is). Instead, we can just
verify in the client after parsing the config, but before sending the job to
the scheduler. E.g. in
[context.py#get_job_config|https://github.com/apache/aurora/blob/master/src/main/python/apache/aurora/client/cli/context.py#L151-L172]
we could add some additional validation logic.
One thing to keep in mind however, is we'd need to be careful that commands on
existing jobs that may have invalid config are still possible. We should only
reject jobs on admission.
was (Author: joshua.cohen):
I don't think we need to do this verification in Pystachio, nor do we need to
write a parser for the DSL (which Pystachio already is). Instead, we can just
verify in the client after parsing the config, but before sending the job to
the scheduler. E.g. in
[context.py#get_job_config](https://github.com/apache/aurora/blob/master/src/main/python/apache/aurora/client/cli/context.py#L151-L172)
we could add some additional validation logic.
One thing to keep in mind however, is we'd need to be careful that commands on
existing jobs that may have invalid config are still possible. We should only
reject jobs on admission.
> Client should reject tasks with duplicate process names
> -------------------------------------------------------
>
> Key: AURORA-1871
> URL: https://issues.apache.org/jira/browse/AURORA-1871
> Project: Aurora
> Issue Type: Task
> Components: Client
> Reporter: Joshua Cohen
>
> If a user creates a job that contains tasks with the same process name, that
> info is happily passed on to thermos, which will happily run one of those
> processes, but maybe display a separate one in the UI. In general the
> behavior in this case is non-deterministic and can lead to hard to track down
> bugs.
> We should just short circuit and fail in the client if we detect multiple
> processes with the same name.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
