[
https://issues.apache.org/jira/browse/AURORA-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981102#comment-13981102
]
Maxim Khutornenko commented on AURORA-222:
------------------------------------------
[~clambert], correct. With the parallel updater this will become obsolete. I'd
say that AURORA-361 should rather drop it completely.
> Updater should run health checks in parallel
> --------------------------------------------
>
> Key: AURORA-222
> URL: https://issues.apache.org/jira/browse/AURORA-222
> Project: Aurora
> Issue Type: Story
> Components: Client
> Reporter: Kevin Sweeney
>
> Right now when the Updater is operating on a batch of instances and those
> instances are configured for health checking it runs their health checks
> sequentially one-instance-at-a-time [1]. This could be trivially
> parallelized, resulting in a speedup of up to the batch size.
> [1]
> https://github.com/apache/incubator-aurora/blob/master/src/main/python/apache/aurora/client/api/instance_watcher.py#L106
> {code}
> for instance_id in instance_ids:
> if instance_id not in finished_instances():
> running_task = tasks_by_instance.get(instance_id)
> if running_task is not None:
> task_healthy, retriable = health_check.health(running_task)
> if task_healthy:
> set_instance_healthy(instance_id, now)
> else:
> maybe_set_instance_unhealthy(instance_id, retriable)
> else:
> # Set retriable=True since an instance should be retried if it
> has not been healthy.
> maybe_set_instance_unhealthy(instance_id, retriable=True)
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
