[
https://issues.apache.org/jira/browse/AURORA-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167094#comment-14167094
]
Bill Farner commented on AURORA-822:
------------------------------------
Two options i see for us right now:
1. make this check more involved by ignoring constructors in anonymous classes
2. remove the check altogether
I'm leaning towards (1) because i think it will be reasonably straightforward
to implement, and we can always fall back to (2). Any other opinions on this?
> Coverage metrics seem occasionally flaky
> ----------------------------------------
>
> Key: AURORA-822
> URL: https://issues.apache.org/jira/browse/AURORA-822
> Project: Aurora
> Issue Type: Bug
> Components: Build
> Reporter: Joshua Cohen
> Priority: Minor
> Attachments: jacocoTestReport.xml, jacocoTestReport.xml
>
>
> [~wfarner] reported a build failure re: newly added coverage:
> {noformat}
> * What went wrong:
> Execution failed for task ':jacocoTestReport'.
> > Thanks for adding the first test coverage to:
> > org/apache/aurora/scheduler/async/OfferQueue$OfferQueueImpl$2 please remove
> > it from the legacyClassesWithoutCoverage list. Expression: (coverage == 0).
> > Values: coverage = 6
> {noformat}
> However running the build locally neither I nor [~zmanji] were able to
> reproduce. Here's the sha I'm running from:
> {noformat}
> $ git log -2
> commit 3a2c17a0d861d624789aad7d7ddd447ab9b866ab
> Author: Joshua Cohen <[email protected]>
> Date: Wed Oct 8 17:11:24 2014 -0700
> Kill code to serve ApiBeta help pages that's no longer used now that the
> content is served directly.
> commit 18ae90569b9a5fda44d0f7a9ea59e8eee916408b
> Author: Zameer Manji <[email protected]>
> Date: Wed Oct 8 16:33:42 2014 -0700
> Blacklist org/apache/aurora/scheduler/http/api/ApiBeta$2 which has no
> coverage.
>
> Bugs closed: AURORA-819
>
> Reviewed at https://reviews.apache.org/r/26464/
> {noformat}
> I'm attaching my jacocoTestReport.xml for further investigation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
