[ 
https://issues.apache.org/jira/browse/AURORA-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173975#comment-14173975
 ] 

Jay Buffington edited comment on AURORA-243 at 10/16/14 5:18 PM:
-----------------------------------------------------------------

[~wfarner] what's your fear?  That mesos-log initialize --path <path> will 
overwrite the existing replicated log?

How about a change to mesos-log to require a --force if the <path> is not 
empty?  Does it already do this (I haven't dug through the code, yet)?  Looks 
like it does:

{noformat}
    $ mesos-log initialize --path=/tmp/foobar/
    I1016 17:17:02.568630  7171 leveldb.cpp:176] Opened db in 3.990557ms
    I1016 17:17:02.570945  7171 leveldb.cpp:183] Compacted db in 1.719964ms
    I1016 17:17:02.570963  7171 leveldb.cpp:198] Created db iterator in 2744ns
    I1016 17:17:02.570977  7171 leveldb.cpp:204] Seeked to beginning of db in 
2704ns
    I1016 17:17:02.570984  7171 leveldb.cpp:273] Iterated through 0 keys in the 
db in 433ns
    I1016 17:17:02.570998  7171 replica.cpp:741] Replica recovered with log 
positions 0 -> 0 with 1 holes and 0 unlearned
    I1016 17:17:02.572597  7175 leveldb.cpp:306] Persisting metadata (8 bytes) 
to leveldb took 649132ns
    I1016 17:17:02.572612  7175 replica.cpp:320] Persisted replica status to 
VOTING

    $ mesos-log initialize --path=/tmp/foobar/
    I1016 17:17:05.510402  7184 leveldb.cpp:176] Opened db in 3.365323ms
    I1016 17:17:05.514776  7184 leveldb.cpp:183] Compacted db in 3.720866ms
    I1016 17:17:05.514812  7184 leveldb.cpp:198] Created db iterator in 4111ns
    I1016 17:17:05.514828  7184 leveldb.cpp:204] Seeked to beginning of db in 
6005ns
    I1016 17:17:05.514857  7184 leveldb.cpp:273] Iterated through 1 keys in the 
db in 20292ns
    I1016 17:17:05.514871  7184 replica.cpp:741] Replica recovered with log 
positions 0 -> 0 with 1 holes and 0 unlearned
    The log is not empty
{noformat}


was (Author: jaybuff):
[~wfarner] what's your fear?  That mesos-log initialize --path <path> will 
overwrite the existing replicated log?

How about a change to mesos-log to require a --force if the <path> is not 
empty?  Does it already do this (I haven't dug through the code, yet)?  Looks 
like it does:

    $ mesos-log initialize --path=/tmp/foobar/
    I1016 17:17:02.568630  7171 leveldb.cpp:176] Opened db in 3.990557ms
    I1016 17:17:02.570945  7171 leveldb.cpp:183] Compacted db in 1.719964ms
    I1016 17:17:02.570963  7171 leveldb.cpp:198] Created db iterator in 2744ns
    I1016 17:17:02.570977  7171 leveldb.cpp:204] Seeked to beginning of db in 
2704ns
    I1016 17:17:02.570984  7171 leveldb.cpp:273] Iterated through 0 keys in the 
db in 433ns
    I1016 17:17:02.570998  7171 replica.cpp:741] Replica recovered with log 
positions 0 -> 0 with 1 holes and 0 unlearned
    I1016 17:17:02.572597  7175 leveldb.cpp:306] Persisting metadata (8 bytes) 
to leveldb took 649132ns
    I1016 17:17:02.572612  7175 replica.cpp:320] Persisted replica status to 
VOTING

    $ mesos-log initialize --path=/tmp/foobar/
    I1016 17:17:05.510402  7184 leveldb.cpp:176] Opened db in 3.365323ms
    I1016 17:17:05.514776  7184 leveldb.cpp:183] Compacted db in 3.720866ms
    I1016 17:17:05.514812  7184 leveldb.cpp:198] Created db iterator in 4111ns
    I1016 17:17:05.514828  7184 leveldb.cpp:204] Seeked to beginning of db in 
6005ns
    I1016 17:17:05.514857  7184 leveldb.cpp:273] Iterated through 1 keys in the 
db in 20292ns
    I1016 17:17:05.514871  7184 replica.cpp:741] Replica recovered with log 
positions 0 -> 0 with 1 holes and 0 unlearned
    The log is not empty

> mesos-log should be auto initialized 
> -------------------------------------
>
>                 Key: AURORA-243
>                 URL: https://issues.apache.org/jira/browse/AURORA-243
>             Project: Aurora
>          Issue Type: Story
>          Components: Continuous Integration
>            Reporter: Jake Farrell
>              Labels: newbie
>
> The replicated log currently requires the invocation of a manual tool to 
> initialize from a full set of empty replicas this is seen in 
> examples/vagrant/provision-aurora-scheduler.sh line 95
> {code}
> mesos-log initialize <path_to_the_log>
> {code}
> Track MESOS-984 and remove this when available 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to