[
https://issues.apache.org/jira/browse/AURORA-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14189357#comment-14189357
]
Bill Farner commented on AURORA-884:
------------------------------------
src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java:
https://reviews.apache.org/r/27363/
> Coverage report analysis may be flaky due to use of Stats
> ---------------------------------------------------------
>
> Key: AURORA-884
> URL: https://issues.apache.org/jira/browse/AURORA-884
> Project: Aurora
> Issue Type: Bug
> Components: Testing
> Reporter: Bill Farner
>
> We use {{Stats.export}} in several places to have closures that export a
> variable, which can be flaky with our code coverage analysis task. If
> {{SchedulerIT}} is not running long enough for a stat sample to take place,
> these classes will be missed. In reality, these classes should be considered
> lacking test coverage if they are only lit up during a stat sample in
> {{SchedulerIT}}.
> Currently-affected code sites:
> {noformat}
> $ grep -R 'Stats.export(new StatImpl' src/main/java/
> src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java:
> Stats.export(new StatImpl<Long>("reservation_cache_size") {
> src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java:
> Stats.export(new StatImpl<Long>("async_tasks_completed") {
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java:
> Stats.export(new StatImpl<Integer>("storage_lock_threads_waiting") {
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java:
> Stats.export(new StatImpl<Integer>("framework_registered") {
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java:
> Stats.export(new StatImpl<Integer>("scheduler_lifecycle_" + state) {
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
