maccamlc commented on pull request #885: URL: https://github.com/apache/avro/pull/885#issuecomment-640462476
> Hello! I'm afraid I've gotten a bit mixed up on what's happening with [AVRO-2493](https://issues.apache.org/jira/browse/AVRO-2493) and [AVRO-2621](https://issues.apache.org/jira/browse/AVRO-2621) -- what is this PR changing now that [AVRO-2493](https://issues.apache.org/jira/browse/AVRO-2493) has been implemented? Are custom logical types still unusable with the avro maven plugin? Initially I was unaware of [AVRO-2493](https://issues.apache.org/jira/browse/AVRO-2493) and was looking to implement a solution against a different ticket. When saw this was merged, for me, the missing part was simply auto registering the used logical type in the Specific code generated classes at [SpecificCompiler#getUsedCustomLogicalTypeFactories](https://github.com/apache/avro/pull/885/files#diff-1131527472ff7e3626a7e126568fedc8), and also added a shortcut to register the [Logical Type](https://github.com/apache/avro/pull/885/files#diff-95cda30d5633f1e967fbe8e873f7a667) using the new type name. From my point of view on the usages, if you have auto generated a class using a logical type, then you probably always expect to also use it at runtime, so removing the need to manually register the types of startup. But if other peoples use cases are different, potentially this could be behind a flag? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
