belugabehr commented on a change in pull request #910:
URL: https://github.com/apache/avro/pull/910#discussion_r436854893
##########
File path: lang/java/pom.xml
##########
@@ -361,6 +361,7 @@
<pluginExecutionFilter>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
+ <version>${spotless-maven-plugin.version}</version>
Review comment:
Truth be told, this builds fine from the command line, but my Eclipse is
unhappy about it, and when Eclipse is unhappy, I am unhappy. :)
Check out the error message again:
```
Missing parameter for pluginExecutionFilter. groupId, artifactId,
versionRange and goals must be specificed, but found: groupId =
'com.diffplug.spotless'
artifactId = 'spotless-maven-plugin'
versionRange = 'null'
goals = '[check]'
```
It requires 5 fields, but only 4 are listed in the "but found" section. The
missing one is `artifiactId`. 'null' perhaps could be a valid value for
`versionRange `
##########
File path: lang/java/pom.xml
##########
@@ -361,6 +361,7 @@
<pluginExecutionFilter>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
+ <version>${spotless-maven-plugin.version}</version>
Review comment:
Truth be told, the current version in trunk builds fine from the command
line, but my Eclipse is unhappy about it, and when Eclipse is unhappy, I am
unhappy. :)
Check out the error message again:
```
Missing parameter for pluginExecutionFilter. groupId, artifactId,
versionRange and goals must be specificed, but found: groupId =
'com.diffplug.spotless'
artifactId = 'spotless-maven-plugin'
versionRange = 'null'
goals = '[check]'
```
It requires 5 fields, but only 4 are listed in the "but found" section. The
missing one is `artifiactId`. 'null' perhaps could be a valid value for
`versionRange `
##########
File path: lang/java/pom.xml
##########
@@ -361,6 +361,7 @@
<pluginExecutionFilter>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
+ <version>${spotless-maven-plugin.version}</version>
Review comment:
Also note that CI does work for JDK8 and JDK 11, so it is building with
the current change.
##########
File path: lang/java/pom.xml
##########
@@ -361,6 +361,7 @@
<pluginExecutionFilter>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
+ <version>${spotless-maven-plugin.version}</version>
Review comment:
Hey Ryan,
Really appreciate the help on this. It's quite annoying.
I just pulled down the latest changes to the master branch and did "Import
[Maven] Project" and when it's doing it's initial build, I get this error
message. Nothing special to it. May be a Eclipse version issue.
if you add both a `<version>` and `<versionRange>` tag, does that build?
That may be the resolution to make all versions happy.
##########
File path: lang/java/pom.xml
##########
@@ -361,6 +361,7 @@
<pluginExecutionFilter>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
+ <version>${spotless-maven-plugin.version}</version>
Review comment:
Hey @RyanSkraba ,
Really appreciate the help on this. It's quite annoying.
I just pulled down the latest changes to the master branch and did "Import
[Maven] Project" and when it's doing it's initial build, I get this error
message. Nothing special to it. May be a Eclipse version issue.
if you add both a `<version>` and `<versionRange>` tag, does that build?
That may be the resolution to make all versions happy.
##########
File path: lang/java/pom.xml
##########
@@ -361,6 +361,7 @@
<pluginExecutionFilter>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
+ <version>${spotless-maven-plugin.version}</version>
Review comment:
I stuck the `version` tag in here, deleted the project, imported it
again, and it came up without the annoying error.
##########
File path: lang/java/pom.xml
##########
@@ -361,6 +361,7 @@
<pluginExecutionFilter>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
+ <version>${spotless-maven-plugin.version}</version>
Review comment:
I suggest just pushing this change to trunk, and if someone is using a
different version of eclipse, we can deal with that in a new Jira/PR
##########
File path: lang/java/pom.xml
##########
@@ -361,6 +361,7 @@
<pluginExecutionFilter>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
+ <version>${spotless-maven-plugin.version}</version>
Review comment:
I suggest just pushing this change to master, and if someone is using a
different version of eclipse, we can deal with that in a new Jira/PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
