kojiromike commented on a change in pull request #929:
URL: https://github.com/apache/avro/pull/929#discussion_r453218926



##########
File path: share/docker/Dockerfile
##########
@@ -62,15 +64,23 @@ RUN apt-get -qqy update \
                                                  python3-setuptools \
                                                  python3-snappy \
                                                  python3-wheel \
-                                                 rake \
-                                                 ruby \
-                                                 ruby-dev \
                                                  source-highlight \
                                                  subversion \
                                                  valgrind \
  && apt-get -qqy clean \
  && rm -rf /var/lib/apt/lists
 
+# Install rbenv and ruby-build

Review comment:
       Please keep the ruby stuff all together in the Dockerfile. Consider 
moving this stuff down to line 174 or moving that stuff up to be part of this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to