cewing commented on pull request #936:
URL: https://github.com/apache/avro/pull/936#issuecomment-663771238
Absolutely this is a disguised form of singledispatch. My first approach
here was really designed to be a drop-in replacement for the existing approach,
which is why it keeps things like dict lookup of validator by schema type (and
now by logical_type as well). It was originally meant to be monkey patched
into place so that we could solve our problem with error messages while the
longer process of this conversation took place.
I'm pretty sure I can make another pass at this that uses `validate` as a
method of the schema class. That would be pretty clean.
Any other thoughts while we look at this first pass?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
