RyanSkraba commented on a change in pull request #938:
URL: https://github.com/apache/avro/pull/938#discussion_r463697700
##########
File path:
lang/java/compiler/src/main/java/org/apache/avro/compiler/specific/SpecificCompiler.java
##########
@@ -287,15 +287,52 @@ public void addCustomConversion(Class<?> conversionClass)
{
}
public Collection<String> getUsedConversionClasses(Schema schema) {
Review comment:
There's some dead code as a consequence of this change:
`getClassNamesOfPrimitiveFields` -- I'm taking a look.
I'm also thinking that if the user explicitly called `addCustomConversion`,
it should be considered "used" and included no matter what, but that currently
isn't the case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
