lukemin89 commented on a change in pull request #955:
URL: https://github.com/apache/avro/pull/955#discussion_r486066261



##########
File path: lang/java/avro/src/main/java/org/apache/avro/util/Utf8.java
##########
@@ -119,16 +120,21 @@ public Utf8 setByteLength(int newLength) {
     }
     this.length = newLength;
     this.string = null;
-    this.hasHash = false;
+    this.hash = 0;

Review comment:
       I personally prefer 0 because all fields get initialized as 0 in Java...
   Would it be okay to leave unchanged?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to