tjwp commented on pull request #918: URL: https://github.com/apache/avro/pull/918#issuecomment-707665522
@andrewthauer - Thank you for offering to help out with this change! I think that the comments from my original review are still relevant. - Full support for decimal logical types requires implementing schema compatibility. Without this a user of the library could accidentally introduce a breaking schema changes believing that something that checks the compatibility would catch it. - Validating the definition of the decimal logical type attributes while encoding each datum is inefficient. This is something that should be done once when the schema is parsed. This also has the benefit of catching errors as soon as the schema is parsed instead of deferring until a datum is eventually encoded for that type. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
