tjwp commented on a change in pull request #918:
URL: https://github.com/apache/avro/pull/918#discussion_r503875434
##########
File path: lang/ruby/lib/avro/logical_types.rb
##########
@@ -16,9 +16,209 @@
# limitations under the License.
require 'date'
+require 'bigdecimal'
+require 'bigdecimal/util'
module Avro
module LogicalTypes
+
+ ##
+ # Base class for logical types requiring a schema to be present
+ class LogicalTypeWithSchema
+ ##
+ # @return [Avro::Schema] The schema this logical type is dealing with
+ attr_reader :schema
+
+ ##
+ # Build a new isntance of a logical type using the provided schema
+ #
+ # @param schema [Avro::Schema]
+ # The schema to use with this instance
+ #
+ # @raise [ArgumentError]
+ # If the provided schema is nil
+ def initialize(schema)
+ raise ArgumentError, 'schema is required' if schema.nil?
+
+ @schema = schema
+ end
+
+ ##
+ # Encode the provided datum
+ #
+ # @param datum [Object] The datum to encode
+ #
+ # @raise [NotImplementedError]
+ # Subclass will need to override this method
+ def encode(datum)
+ raise NotImplementedError
+ end
+
+ ##
+ # Decode the provided datum
+ #
+ # @param datum [Object] The datum to decode
+ #
+ # @raise [NotImplementedError]
+ # Subclass will need to override this method
+ def decode(datum)
+ raise NotImplementedError
+ end
+ end
+
+ ##
+ # Logical type to handle arbitrary-precision decimals using byte array.
+ #
+ # The byte array contains the two's-complement representation of the
unscaled integer
+ # value in big-endian byte order.
+ class BytesDecimal < LogicalTypeWithSchema
+ # Messages for exceptions
+ ERROR_INSUFICIENT_PRECISION = 'Precision is too small'.freeze
+ ERROR_INVALID_SCALE = 'Scale must be greater than or equal to
0'.freeze
+ ERROR_INVALID_PRECISION = 'Precision must be positive'.freeze
+ ERROR_PRECISION_TOO_SMALL = 'Precision must be greater than
scale'.freeze
+ ERROR_ROUNDING_NECESSARY = 'Rounding necessary'.freeze
+ ERROR_VALUE_MUST_BE_NUMERIC = 'value must be numeric'.freeze
+
+ # The pattern used to pack up the byte array (8 bit unsigned
integer/char)
+ PACK_UNSIGNED_CHARS = 'C*'.freeze
+
+ # The number 10 as BigDecimal
+ TEN = BigDecimal(10).freeze
+
+ ##
+ # @return [Integer] The number of total digits supported by the decimal
+ attr_reader :precision
+
+ ##
+ # @return [Integer] The number of fractional digits
+ attr_reader :scale
+
+ ##
+ # Build a new decimal logical type
+ #
+ # @param schema [Avro::Schema]
+ # The schema defining precision and scale for the conversion
+ #
+ # @raise [ArgumentError]
+ # If precision or scale have invalid values. Precision must be
+ # positive and greater or equal to scale. If scale is missing,
+ # it defaults to 0.
+ def initialize(schema)
Review comment:
I wouldn't suggest a cache for this, but instead something that is
stored for the associated `BytesSchema` instance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
