blackeyepanda commented on pull request #949: URL: https://github.com/apache/avro/pull/949#issuecomment-890563724
> > ``` > > * My PR adds the following unit tests OR does not need testing for this extremely good reason: > > No new tests added, local c++ tests has been passed > > ``` > > IMO you need to add some new test that fails without the fix and passes with it. test added, `datum.logicalType().type()` will be `LogicalType::NONE` before fix and now `LogicalType::UUID` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
