wx930910 commented on a change in pull request #1341:
URL: https://github.com/apache/avro/pull/1341#discussion_r711798004
##########
File path:
lang/java/compiler/src/test/java/org/apache/avro/compiler/schema/TestSchemas.java
##########
@@ -38,36 +59,11 @@
+ "
{\"name\":\"methodName\",\"type\":{\"type\":\"string\",\"avro.java.string\":\"String\"}}\n"
+ " ]}},\n" + "
{\"name\":\"node\",\"type\":\"SampleNode\"}]}}}" + "]}";
- private static class PrintingVisitor implements SchemaVisitor {
-
- @Override
- public SchemaVisitorAction visitTerminal(Schema terminal) {
- System.out.println("Terminal: " + terminal.getFullName());
- return SchemaVisitorAction.CONTINUE;
- }
-
- @Override
- public SchemaVisitorAction visitNonTerminal(Schema terminal) {
- System.out.println("NONTerminal start: " + terminal.getFullName());
- return SchemaVisitorAction.CONTINUE;
- }
-
- @Override
- public SchemaVisitorAction afterVisitNonTerminal(Schema terminal) {
- System.out.println("NONTerminal end: " + terminal.getFullName());
- return SchemaVisitorAction.CONTINUE;
- }
-
- @Override
- public Object get() {
- return null;
- }
Review comment:
Yes I agree with you. But just adding the print info doesn't effect the
testing result, won't it better to explictly verify the execution times and
order to enpower the test? Do you think the verification of execution order
seems redundant in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
