gudjonragnar commented on a change in pull request #1340:
URL: https://github.com/apache/avro/pull/1340#discussion_r713747331



##########
File path: lang/rust/tests/schema.rs
##########
@@ -19,6 +19,13 @@
 use avro_rs::{schema::Name, Error, Schema};
 use lazy_static::lazy_static;
 
+fn init() {

Review comment:
       ye I agree, or even something like pytests fixtures. 
   I see your point with possibly adding more to the init, however I often 
favour separating the `inits` unless they are necessary inits for all of the 
tests. In this case it is more of a nitpick comment, so I don't mind you 
disregarding it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to