RyanSkraba commented on a change in pull request #1356:
URL: https://github.com/apache/avro/pull/1356#discussion_r724759053
##########
File path: lang/js/package-lock.json
##########
@@ -1,2260 +1,8 @@
{
"name": "avro-js",
- "version": "1.11.0-SNAPSHOT",
- "lockfileVersion": 2,
+ "version": "1.12.0-SNAPSHOT",
+ "lockfileVersion": 1,
"requires": true,
- "packages": {
Review comment:
This is kind of tricky! We bumped `lockfileVersion` to 2, which seemed
like the right thing to do, but since build/release process uses the oldest
supported version of Node.js, this file is *always* updated after a build.
That doesn't seem right to me either, so I checked in the file created "using
the tools at time of bump".
What do you think? What's the right thing to do for a node.js developer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
