opwvhk commented on a change in pull request #1407:
URL: https://github.com/apache/avro/pull/1407#discussion_r753209184
##########
File path:
lang/java/compiler/src/main/javacc/org/apache/avro/compiler/idl/idl.jj
##########
@@ -1317,17 +1317,9 @@ void FieldDeclaration(List<Field> fields):
Map<String, JsonNode> props = new LinkedHashMap<String, JsonNode>();
}
{
- // TODO should we be able to specify properties on any Type?
- // or just on field declarations as done here
-
- ( SchemaProperty(props) )*
type = Type()
VariableDeclarator(type, fields) ( "," VariableDeclarator(type, fields) )*
";"
- {
- for (String key : props.keySet())
- Accessor.addProp(type, key, props.get(key));
- }
Review comment:
The Type() production already handles properties; no need to add them
here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
