opwvhk commented on a change in pull request #1412:
URL: https://github.com/apache/avro/pull/1412#discussion_r755790470
##########
File path:
lang/java/compiler/src/main/javacc/org/apache/avro/compiler/idl/idl.jj
##########
@@ -1349,7 +1349,7 @@ void VariableDeclarator(Schema type, List<Field> fields):
if ("order".equals(key))
order =
Field.Order.valueOf(getTextProp(key,props,token).toUpperCase());
- boolean validate = !SchemaResolver.isUnresolvedSchema(type);
+ boolean validate = SchemaResolver.isFullyResolvedSchema(type);
Review comment:
This ensures we only validate fields if the schema is (recursively)
resolved.
Note that although this triggers validation less often, every default value
is still validated because `ResolvingVisitor` copies the entire schema, and
thus (re)validates all default values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
