martin-g commented on a change in pull request #1411:
URL: https://github.com/apache/avro/pull/1411#discussion_r766092460
##########
File path: lang/java/compiler/src/test/idl/input/simple.avdl
##########
@@ -60,7 +60,7 @@ protocol Simple {
time_ms t = 0;
@foo.bar("bar.foo") long l = 0;
- union {null, @foo.foo.bar(42) @foo.foo.foo("3foo") string} prop = null;
+ @foo.foo.bar(42) @foo.foo.foo("3foo") string? prop = null;
Review comment:
IMO it would be good to add some comments next to the modified fields,
for the future reader/you.
E.g. next to `time_ms? t = 0` we could add a comment like: `demonstrates a
union schema with nonNull default value, so the nonNull schema is first`.
And next to `string? prop = null;` we could add a comment like:
`demonstrates a union schema with null default value, so the nonNull schema is
second`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
