KyleSchoonover commented on a change in pull request #1480:
URL: https://github.com/apache/avro/pull/1480#discussion_r795247010
##########
File path: lang/csharp/src/apache/main/CodeGen/CodeGen.cs
##########
@@ -220,7 +227,10 @@ protected virtual SchemaNames generateNames(Schema schema)
protected virtual void addName(Schema schema, SchemaNames names)
{
NamedSchema ns = schema as NamedSchema;
- if (null != ns) if (names.Contains(ns.SchemaName)) return;
+ if (ns != null && names?.Contains(ns.SchemaName) == true)
Review comment:
Putting names? would be the equivalent of (assuming names is null) null
== true. I've reverted the change back. I think I was future proofing some
null argument checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
