KyleSchoonover commented on a change in pull request #1495:
URL: https://github.com/apache/avro/pull/1495#discussion_r796666771
##########
File path: lang/csharp/src/apache/main/File/DataFileConstants.cs
##########
@@ -21,9 +21,6 @@ namespace Avro.File
/// <summary>
/// Constants used in data files.
/// </summary>
- [System.Diagnostics.CodeAnalysis.SuppressMessage("Design",
- "CA1052:Static holder types should be Static or NotInheritable",
- Justification = "Maintain public API")]
Review comment:
It was, but it's an old rule. The way you get rid of it, is just make
the static property readonly. Allows you to essentially make a static property
a constant. The reason you do this is because constants are basic types and
not a reference type like an array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
