martin-g commented on a change in pull request #1438:
URL: https://github.com/apache/avro/pull/1438#discussion_r796969994
##########
File path: lang/csharp/src/apache/test/Schema/SchemaTests.cs
##########
@@ -167,6 +167,49 @@ private static void testToString(Schema sc)
}
}
+ [TestCase("{ \"type\": \"null\", \"metafield\": \"abc\" }",
Schema.Type.Null)]
+ [TestCase("{ \"type\": \"boolean\", \"metafield\": \"abc\" }",
Schema.Type.Boolean)]
+ [TestCase("{ \"type\": \"int\", \"metafield\": \"abc\" }",
Schema.Type.Int)]
+ [TestCase("{ \"type\": \"long\", \"metafield\": \"abc\" }",
Schema.Type.Long)]
+ [TestCase("{ \"type\": \"float\", \"metafield\": \"abc\" }",
Schema.Type.Float)]
+ [TestCase("{ \"type\": \"double\", \"metafield\": \"abc\" }",
Schema.Type.Double)]
+ [TestCase("{ \"type\": \"bytes\", \"metafield\": \"abc\" }",
Schema.Type.Bytes)]
+ [TestCase("{ \"type\": \"string\", \"metafield\": \"abc\" }",
Schema.Type.String)]
+ public void TestPrimitiveWithMetadata(string s, Schema.Type type)
+ {
+ Schema sc1 = Schema.Parse(s);
Review comment:
Please use better names for the variables than `s`, `sc1`, `rc`, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
