KyleSchoonover commented on a change in pull request #1549:
URL: https://github.com/apache/avro/pull/1549#discussion_r806245227
##########
File path: lang/csharp/src/apache/main/Generic/GenericWriter.cs
##########
@@ -29,59 +30,63 @@ namespace Avro.Generic
public delegate void Writer<T>(T t);
/// <summary>
- /// A typesafe wrapper around DefaultWriter. While a specific object of
DefaultWriter
+ /// A type-safe wrapper around DefaultWriter. While a specific object of
DefaultWriter
/// allows the client to serialize a generic type, an object of this class
allows
/// only a single type of object to be serialized through it.
/// </summary>
/// <typeparam name="T">The type of object to be serialized.</typeparam>
+ /// <seealso cref="DatumWriter<T>" />
public class GenericWriter<T> : DatumWriter<T>
{
- private readonly DefaultWriter writer;
+ private readonly DefaultWriter _writer;
/// <summary>
- /// Initializes a new instance of the <see cref="GenericWriter{T}"/>
class.
+ /// Initializes a new instance of the <see cref="GenericWriter{T}" />
class.
/// </summary>
/// <param name="schema">Schema to use when writing.</param>
public GenericWriter(Schema schema) : this(new DefaultWriter(schema))
{
-
}
/// <inheritdoc/>
- public Schema Schema { get { return writer.Schema; } }
+ public Schema Schema
+ { get { return _writer.Schema; } }
Review comment:
I've been trying to remember the rule that requests you do that. I used
to do it for any single line method as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
