zcsizmadia edited a comment on pull request #1549: URL: https://github.com/apache/avro/pull/1549#issuecomment-1039628288
@KyleSchoonover @martin-g @RyanSkraba I start to loose confidence in myself that this is the right way to handle this. I still beleive that this effort should be grouped by warning type and not by a massive rework all warnings. IMO formatting warnings can be fixed easily, however changing massive code for reworking conditions and casting seems dangerous to me. It is hard to review so much code and the compiler suggestion IMO cannot be trusted 100%. Any comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
