zcsizmadia edited a comment on pull request #1534: URL: https://github.com/apache/avro/pull/1534#issuecomment-1040542379
My suggestion would be that PRs are grouped around the compiler warning. Eg. 1 PR fixes 1 particular compiler warning. In that case thereviewer has an easier job, just focusing one kind of change. If the PR is "too big" it might have to be split into multiple ones. I am not sure what is a too big PR btw. Compiler codes to fix: IDE0001 IDE0002 IDE0003 IDE0004 IDE0005 IDE0034 IDE0036 IDE0040 IDE0044 IDE0049 IDE0055 IDE0059 IDE0071 IDE0076 IDE0078 IDE0079 Compiler codes to turn off for now: IDE0017 IDE0018 IDE0019 IDE0028 IDE0029 IDE0041 IDE0038 IDE0045 IDE0046 IDE0066 In the PRs the main objective should be that it is as reviewer friendly as possible, so the diff is as easily readable as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
