zcsizmadia commented on pull request #1571: URL: https://github.com/apache/avro/pull/1571#issuecomment-1053704185
I have multiple issues: It feels that using an extension is an overkill in this situation and not the proper usage of an extension 1. The functionality belongs to the Schema or Schema.Type object more than to the string. 2. You have access to the Schema object source code. The bigger issue I have is that it will change the existing code behaviour. Currently the reason behind the big switch is to specify the supported keywords as the type name, which are nul,, boolean,.... With this change, nULl, DoUbLe, StrinG would become keywords which are accepted and valid by `PrimitiveSchema.NewInstance`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
