KyleSchoonover commented on pull request #1571: URL: https://github.com/apache/avro/pull/1571#issuecomment-1053734997
That's exactly why I wanted to have this conversation. Extension methods aside I wanted a centralized place to put this functionality for reuse. And it looks like you are in favor of strict parsing, ie the switch statement. I think in this case you are correct because it extends string over really being able to extend the enum. I will call out though that any time I hear the word util or helper, I really question if it should be an extension method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
