martin-g commented on a change in pull request #1580:
URL: https://github.com/apache/avro/pull/1580#discussion_r820393107
##########
File path: lang/rust/avro/src/schema.rs
##########
@@ -241,17 +242,41 @@ impl Name {
}
}
+ /// Create a new `Name`.
+ /// Parses the optional `namespace` from the `name` string.
+ /// `aliases` will not be defined.
+ pub fn parse_str(name: &str) -> Name {
Review comment:
I also wondered whether to modify `new()` but its documentation
explicitly says that it doesn't parse and set the namespace.
Since you also noticed it I think we should just do it, because currently
`new()` is broken!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
