opwvhk commented on a change in pull request #1355:
URL: https://github.com/apache/avro/pull/1355#discussion_r820460191
##########
File path:
lang/java/avro/src/main/java/org/apache/avro/reflect/ReflectDatumReader.java
##########
@@ -70,18 +72,13 @@ public ReflectDatumReader(ReflectData data) {
super(data);
}
- @Override
- protected Object newArray(Object old, int size, Schema schema) {
+ protected Object newArray(Object old, int size, Schema schema, Class<?> cls)
{
Class<?> collectionClass = ReflectData.getClassProp(schema,
SpecificData.CLASS_PROP);
- Class<?> elementClass = ReflectData.getClassProp(schema,
SpecificData.ELEMENT_PROP);
+ // java-element-class takes priority
Review comment:
> java-element-class takes priority
Should be: java-element-class takes priority over cls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
