kordos commented on pull request #1578: URL: https://github.com/apache/avro/pull/1578#issuecomment-1060735692
> The reason I am asking is that if you have only 1 or a very few schema files you work with, the chance for name collision is very small or 0. As soon as you have many schemas to compile, like many projects do, the chance for a type name collision is getting higher since you are flattening the directory structure. This is the main reason many C# source codes are following that pattern of matching the namespace with the directory structure. > > Of course avrogen wont be really able to detect and report collisions, potentially causing the developer headache to figure out what went wrong, when the generated code does not even compile. > > So this was the reason behind my question about what use case you try to cover with this feature ;) Namespace for classes isn't changed and classes are generated with full namespace. Just avrogen is putting them in wrong directory when directories have many namespaces in it (/foo.bar.api/ is a one directory) with current implementation of avrogen I have to generate classes, then manually move them from wrongly generated path to correct path, and manually remove wrong directories. It's very annoying and not the best user experience ;) Tool is not handling multi namespaces directories. In order to avoid that my change generate classes in output directory, without creating of namespace directories. I'm not sure if my clarification helps to understand the problem... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
