travisbrown commented on pull request #1582: URL: https://github.com/apache/avro/pull/1582#issuecomment-1061521571
@jklamer That approach looks reasonable to me, including the names, although off the top of my head I don't know what terminology the Java tooling uses here, and I think it would make sense to aim for consistency. Semi-relatedly, the idea of `Name` being hashed and compared by fullname with the specific representation and aliases being ignored seems like it could cause problems down the line: sooner or later someone will try to put them in a set, etc., and get an unpleasant surprise. What do you think about something like having a `Fullname` type that would be a simple string wrapper with a safe constructor, using that for these map keys, and having `fullname()` on `Name` return `Fullname` instances? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
