opwvhk commented on pull request #1584: URL: https://github.com/apache/avro/pull/1584#issuecomment-1071121085
> hi! Are there any other concerns for this PR? Only one: convertible from a CharSequence doesn't yet take the scale into account. It should, because otherwise reading data can result in a BigDecimal with an unexpected scale. Simply setting the scale with `RoundingMode.UNNECESSARY` is sufficient; evolution to a larger will then still work, but evolution to a smaller scale will only succeed if the value allows it (as it should). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
