anekdoti commented on a change in pull request #1622:
URL: https://github.com/apache/avro/pull/1622#discussion_r834461751
##########
File path: lang/csharp/src/apache/test/Generic/GenericTests.cs
##########
@@ -37,6 +37,45 @@ private static void test<T>(string s, T value)
Assert.AreEqual(value, output);
}
+ [Test]
Review comment:
Thank you very much for the comment! I will add further tests. In
regards to the two problematic cases you have discovered:
1. The conversion from the base value to the logical value in
https://github.com/apache/avro/blob/master/lang/csharp/src/apache/main/Util/TimestampMicrosecond.cs
is responsible for this. If this can be changed at all I would consider this a
new PR.
2. Decimal uses either "bytes" or "fixed" as the underlying base schema.
Both are represented as a string in the Avro JSON representation, but these
strings should not contain a decimal encoding but a binary encoding of a
decimal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
