zcsizmadia commented on a change in pull request #1622:
URL: https://github.com/apache/avro/pull/1622#discussion_r834510189
##########
File path: lang/csharp/src/apache/test/Generic/GenericTests.cs
##########
@@ -37,6 +37,45 @@ private static void test<T>(string s, T value)
Assert.AreEqual(value, output);
}
+ [Test]
Review comment:
I agree on the assessment of the the 2 issues. I would ignore the
decimal unit test failures, however the micros are a bigger issue. I would fix
that first and put this PR on hold until that is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
